Spending many years on one book isn’t productive, I agree. I also see authors talk about generating 1,2,3 even 4 books per year, every year and that’s the other end of the scale. It’s a personal balancing act. Long literary novels will take more time than short series or (non fiction) self-help.